Merging dev to main #65
Conversation
new aerodyn input format - removed AFAeroMod and WakeMod is now Wake_Mod Co-authored-by: DT4015 <[email protected]>
* Update of FAST.Farm for windows * Fixing unittests
* Updates from welib * Adding IEA15 model * Adding Example 0, update Example 1 so it can run on github action * Adapting Example 2 for FAST.Farm so it can run on github action * Adapting Example 3 for FAST.Farm so it can run on github action * Adding real_all io unittest, and verbose flag to unittest
|
@mayankchetan, can you review this? |
There was a problem hiding this comment.
Pull Request Overview
This PR merges development changes to main, primarily including fixes for unit tests and updates to IEA 15MW turbine airfoil data files.
- Fixes broken unit tests that had been failing for some time
- Updates numerous IEA 15MW airfoil polar data files with new aerodynamic coefficients
- Adds verbose output to test commands for better debugging
Reviewed Changes
Copilot reviewed 77 out of 173 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Multiple IEA-15-240-RWT_AeroDyn15_Polar_*.dat | New airfoil polar data files containing aerodynamic coefficients for the IEA 15MW turbine |
| IEA-15-240-RWT_AF49_Coords.txt | New airfoil coordinate file defining the shape of airfoil section 49 |
| data/.gitignore | Adds .lin and .sum.yaml files to gitignore |
| Makefile | Adds verbose flag to unittest command |
| .github/workflows/development-pipeline.yml | Adds verbose flag to unittest command in CI pipeline |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mayankchetan
left a comment
mayankchetan
left a comment
There was a problem hiding this comment.
That's a lot of changes and updates!! Thanks Emmanuel! :)
|
@rthedin had worked quite a bit to get the toolbox to generate FF input files that run with TurbSim again. things weren't really working yet and I opened rthedin#3 waiting for a review. I've reviewed this PR and so much has changed that I am not sure anymore whether this will work with TurbSim. @ebranlard can you confirm? |
|
@ebranlard I'm working on this PR. Will keep posting comments as I go and will let you know when I'm done. |
- TS_low_dummy was introcuced in PR69 but we already had a mechanism for it (using the `runOnce` flag. - The check of the output of turbsim was there before and was removed on PR69, only checking the presence and non-zero-bytes value of the output files. Now we put the check back. PR69 handles the errors in a different way and thus wouldn't need this check, but when using SLURM scripts it is still needed
the skipcheck flag allows us to test all the way to FF_setup, as opposed to stopping at the low-res generation
Removed in PR69, now added back in a more robust way. Just checking the existence of the file is not enough.
Updates to dev following PR#65
|
Thanks @ebranlard for this PR. Lots of changes there. I went through it in details and tested many of my setups. I pushed several little changes and a few bug fixes on top of your modifications. I left most I see now it's failing a few tests on your reader. I only modified FAST.Farm related files and all the FF tests were passed under #73. Could you take a loot at the failing reader tests? |
|
I've fixed the failing tests. Recently, I've had to introduce some changes to the fast_input_file reader / writer for some recent OpenFAST file. Let me know if you notice any issue with this class, I can fix it and add additional input files to the list of test for the IO library. |
6 participants
Contains:
Mostly affects FAST.Farm.